Fix broken Gulp setup and align it with repo structure#5934
Closed
Chaitu7032 wants to merge 1 commit intosugarlabs:masterfrom
Closed
Fix broken Gulp setup and align it with repo structure#5934Chaitu7032 wants to merge 1 commit intosugarlabs:masterfrom
Chaitu7032 wants to merge 1 commit intosugarlabs:masterfrom
Conversation
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
This PR fixes the Gulp configuration so it matches the actual repository structure and does not fail immediately when contributors try to run it.
Problem
The current Gulp setup had multiple guaranteed breakpoints:
gulpfile.jsused an incorrect Babel preset and was not reliable to run.gulpfile.mjsreferenced:- a SASS path that does not exist in this repo
(scss/**/*.scss)-
gulp-rename, which was not installed, causing an immediate runtime errorAs a result, running Gulp would fail even before any build logic could execute.
Changes
Retired the broken CommonJS gulpfile by renaming it to
gulpfile.legacy.jsand marking it as legacy / reference-only.Updated
gulpfile.mjsto match the repo’s actual SASS layout:-
scss/**/*.scss→css/**/*.sassAdded the missing dependency required by
gulpfile.mjs:- added gulp-rename to devDependencies
Why this change is safe
How to test
expected -
Gulp now loads the ESM gulpfile without crashing.
Gulp runs successfully; Sass emits deprecation warnings for legacy @import usage, which existed before this change and are not addressed here to keep the PR focused. It’s a warning, not a failure, and nothing breaks .
Notes
npm installreports existing vulnerabilities vianpm audit.