Skip to content

Fix broken Gulp setup and align it with repo structure#5934

Closed
Chaitu7032 wants to merge 1 commit intosugarlabs:masterfrom
Chaitu7032:gulpfix2
Closed

Fix broken Gulp setup and align it with repo structure#5934
Chaitu7032 wants to merge 1 commit intosugarlabs:masterfrom
Chaitu7032:gulpfix2

Conversation

@Chaitu7032
Copy link
Contributor

PR Description

Summary

This PR fixes the Gulp configuration so it matches the actual repository structure and does not fail immediately when contributors try to run it.

Problem

The current Gulp setup had multiple guaranteed breakpoints:

  • The CommonJS gulpfile.js used an incorrect Babel preset and was not reliable to run.
  • The ESM gulpfile.mjs referenced:
    - a SASS path that does not exist in this repo (scss/**/*.scss)
    - gulp-rename, which was not installed, causing an immediate runtime error

As a result, running Gulp would fail even before any build logic could execute.

Changes

  • Retired the broken CommonJS gulpfile by renaming it to gulpfile.legacy.js and marking it as legacy / reference-only.

  • Updated gulpfile.mjs to match the repo’s actual SASS layout:
    - scss/**/*.scsscss/**/*.sass

  • Added the missing dependency required by gulpfile.mjs:
    - added gulp-rename to devDependencies

Why this change is safe

  • No build system rewrite.
  • No new tasks or output files added.
  • No changes to existing CSS or JS output.
  • This only aligns existing tooling with the files and dependencies already present in the repo.

How to test

image

expected -

image
  • Gulp now loads the ESM gulpfile without crashing.

  • Gulp runs successfully; Sass emits deprecation warnings for legacy @import usage, which existed before this change and are not addressed here to keep the PR focused. It’s a warning, not a failure, and nothing breaks .

Notes

  • npm install reports existing vulnerabilities via npm audit.
  • This PR intentionally does not address them to keep the scope limited to fixing Gulp breakpoints only.

@github-actions
Copy link
Contributor

✅ All Jest tests passed! This PR is ready to merge.

@Chaitu7032 Chaitu7032 closed this Feb 27, 2026
@Chaitu7032 Chaitu7032 deleted the gulpfix2 branch February 27, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant